[webkit-reviews] review denied: [Bug 40447] Infinite loop in WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded : [Attachment 99278] Fix performance / memory allocation problem

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied eustas.bug at gmail.com's request
for review:
Bug 40447: Infinite loop in
WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=40447

Attachment 99278: Fix performance / memory allocation problem
https://bugs.webkit.org/attachment.cgi?id=99278&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99278&action=review

> Source/WebCore/ChangeLog:5
> +	   Performance / memory allocation issue in
WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded

Please add WebInspector: prefix.

> LayoutTests/ChangeLog:5
> +	   Performance / memory allocation issue in
WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded

Ditto

> LayoutTests/inspector/editor/text-editor-model-replace-tabs.html:12
> +	var input = testCases[i];

weird indent, otherwise looks good.

> LayoutTests/inspector/editor/text-editor-model-replace-tabs.html:22
> +    var bufT = [];

nit: no abbreviations in webkit (bufferT & bufferS)