[webkit-reviews] review denied: [Bug 40447] Infinite loop in WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded : [Attachment 99255] Fix performance / memory allocation problem

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied eustas.bug at gmail.com's request
for review:
Bug 40447: Infinite loop in
WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=40447

Attachment 99255: Fix performance / memory allocation problem
https://bugs.webkit.org/attachment.cgi?id=99255&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99255&action=review

> Source/WebCore/ChangeLog:5
> +	   Performance / memory allocation issue in
WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded

Web Inspector: prefix missing

> LayoutTests/ChangeLog:5
> +	   Performance / memory allocation issue in
WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded

ditto

> LayoutTests/inspector/editor/text-editor-model-replace-tabs-expected.txt:16
> +[]

It'd be nicer to print results side by side with the source lines. You should
also render tab as \t in the source to avoid possible confusions (I have tab
rendered as 8 spaces in my settings).

> LayoutTests/inspector/editor/text-editor-model-replace-tabs.html:35
> +	       result = "FAIL: time limit (100ms) exceeded (execution time: " +
duration + "ms)"

This won't work on the bots. Things may take seconds there. Please do not test
performance in the layout tests - they become flaky. As we agree, measuring
correctness is sufficient.