[webkit-reviews] review denied: [Bug 63648] Severe shadow repaint issues with SVGText elements : [Attachment 99150] Even more reasonable patch!

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 30 01:33:32 PDT 2011


Nikolas Zimmermann <zimmermann at kde.org> has denied  review:
Bug 63648: Severe shadow repaint issues with SVGText elements
https://bugs.webkit.org/show_bug.cgi?id=63648

Attachment 99150: Even more reasonable patch!
https://bugs.webkit.org/attachment.cgi?id=99150&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Hm, we're intentionally not using the layout overflow mechanism anywhere in
SVG.
We actually consider text shadow in:

FloatRect RenderSVGText::repaintRectInLocalCoordinates() const

    FloatRect repaintRect = strokeBoundingBox();
    SVGRenderSupport::intersectRepaintRectWithResources(this, repaintRect);

    if (const ShadowData* textShadow = style()->textShadow())
	textShadow->adjustRectForShadow(repaintRect);

    return repaintRect;
}

Is this not enough? If so why?


More information about the webkit-reviews mailing list