[webkit-reviews] review granted: [Bug 56397] Suppress modal JavaScript/HTML dialogs during unload events : [Attachment 99227] Updated test and expectations

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Sreeram Ramachandran
<sreeram at chromium.org>'s request for review:
Bug 56397: Suppress modal JavaScript/HTML dialogs during unload events
https://bugs.webkit.org/show_bug.cgi?id=56397

Attachment 99227: Updated test and expectations
https://bugs.webkit.org/attachment.cgi?id=99227&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99227&action=review

Very nice.  Thanks for iterating on the patch.

> Source/WebCore/page/Chrome.cpp:209
> +static bool canRunModalIfDuringPageDismissal(Page* page, ChromeClient*
client, ChromeClient::DialogType dialog, const String& message)

This is fine, but ChromeClient can be reached from Page, so you could just pass
Page, but whatever.