[webkit-reviews] review granted: [Bug 63532] DRT: Make Hixie76WebSocketProtocolEnabled preference flag configurable from LayoutTestController : [Attachment 99060] Patch v2

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 63532: DRT: Make Hixie76WebSocketProtocolEnabled preference flag
configurable from LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=63532

Attachment 99060: Patch v2
https://bugs.webkit.org/attachment.cgi?id=99060&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99060&action=review

>>> Tools/DumpRenderTree/chromium/WebPreferences.cpp:113
>>> +	 hixie76WebSocketProtocolEnabled = true;
>> 
>> Is the default value true?
>> 
>> What's your testing plan? Will we have tests for the current protocol and
tests for the new protocol? What tests should call overridePreference()?
> 
> At least for now, I want to make the default value true to keep existing
tests as-is (note that Hixie76 is an old protocol, so this means "we use the
old protocol by default.")
> 
> I'm going to update WebSocket tests in the following way:
> 1) Move existing tests (using the old hixie76 protocol) under a new directory
(say, websocket/tests/hixie76).
> 2) Put tests for the new protocol. Each test should have a line
"overridePreference("WebKitHixie76WebSocketProtocolEnabled", 0)" in the
beginning. We can copy most tests from hixie76 tests, but some tests will need
manual modifications, hence they will diverge from hixie76 tests.
> 3) Make changes...
> 4) When we are sure about flipping default to the new protocol, put
"overridePreference("WebKitHixie76WebSocketProtocolEnabled", 1)" to every
hixie76 tests, and flip the default value.
> 5) When we are sure about dropping support for the old protocol, remove tests
for the old protocol, Settings item, "overridePreference()" calls, etc.
> 
> So my answers to your last two questions are:
> - Meanwhile, we will have to maintain two sets of tests: one for the old
protocol, and one for the new protocol. I expect this period will not last
long.
> - Meanwhile, only new tests should call overridePreference() (because the old
protocol is default). This will change as the default changes.

ok, I understand.  The initial value of
Settings:m_useHixie76WebSocketProtocol() is also true.	Resetting to true is
reasonable.