[webkit-reviews] review granted: [Bug 63501] Simplify Skipped file finding and make it wk2-aware : [Attachment 99179] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 29 16:41:36 PDT 2011
Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 63501: Simplify Skipped file finding and make it wk2-aware
https://bugs.webkit.org/show_bug.cgi?id=63501
Attachment 99179: Patch
https://bugs.webkit.org/attachment.cgi?id=99179&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99179&action=review
I mean, ideally you'd separate out the cleanup from the real change, but ok.
> Tools/Scripts/webkitpy/layout_tests/port/gtk.py:71
> def check_build(self, needs_http):
> - if not self._check_driver():
> - return False
> - return True
> + return self._check_driver()
Wow
More information about the webkit-reviews
mailing list