[webkit-reviews] review denied: [Bug 63632] [CSS Regions] Add support for skipped tests : [Attachment 99163] Add testcase to populate path to skip

Wed Jun 29 16:09:07 PDT 2011

Tony Chang <tony at chromium.org> has denied Alan Stearns <stearns at adobe.com>'s
request for review:
Bug 63632: [CSS Regions] Add support for skipped tests
https://bugs.webkit.org/show_bug.cgi?id=63632

Attachment 99163: Add testcase to populate path to skip
https://bugs.webkit.org/attachment.cgi?id=99163&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99163&action=review

Some minor nits to the test file.

> LayoutTests/fast/regions/flow-content-basic.html:1
> +<head>

<!DOCTYPE HTML>

> LayoutTests/fast/regions/flow-content-basic.html:6
> +    <!-- this test checks that content can be redirected to a region. It
also
> +	       tries out a validation strategy that recreates the intended
display
> +	       using non-region markup. If top does not match the bottom then
the 
> +	       result should be rejected -->

This indenting looks weird, maybe some tabs snuck in?  Also 'this test' ->
'This test' and end the last sentence with a period.

> LayoutTests/fast/regions/flow-content-basic.html:26
> +<body onload="runTests();">

This onload doesn't look used.