[webkit-reviews] review granted: [Bug 63657] Remove ElementWithPseudoId, since now an Element can store it all by itself. : [Attachment 99148] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 29 14:55:05 PDT 2011


Kent Tamura <tkent at chromium.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 63657: Remove ElementWithPseudoId, since now an Element can store it all by
itself.
https://bugs.webkit.org/show_bug.cgi?id=63657

Attachment 99148: Patch
https://bugs.webkit.org/attachment.cgi?id=99148&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99148&action=review

> Source/WebCore/html/ValidationMessage.cpp:135
>      host->ensureShadowRoot()->appendChild(m_bubble.get(), ec);
>  

nit: We had better have ASSERT(!ec);


More information about the webkit-reviews mailing list