[webkit-reviews] review granted: [Bug 63660] Only enable TestWebKitAPI on bots on win and mac-snowleopard : [Attachment 99153] The fix

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Dmitry Lomov
<dslomov at google.com>'s request for review:
Bug 63660: Only enable TestWebKitAPI on bots on win and mac-snowleopard
https://bugs.webkit.org/show_bug.cgi?id=63660

Attachment 99153: The fix
https://bugs.webkit.org/attachment.cgi?id=99153&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=99153&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:539
> +	   if configuration == "debug" and (platform == 'mac-snowleopard' or
platform == 'win'):

It would be nice if we didn't have to change this line of code once we have a
mac-lion bot.

The mixture of single- and double-quotes here is strange.

I'd write the second part as:  platform in ('mac-snowleopard, 'win')

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:562
> +	   if configuration == "debug" and (platform == 'mac-snowleopard' or
platform == 'win'):

Same comments as above.