[webkit-reviews] review granted: [Bug 63558] Media element loads blocked by a resource load delegate or beforeload handler do not generate an error event : [Attachment 99099] Proposed patch.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 63558: Media element loads blocked by a resource load delegate or
beforeload handler do not generate an error event
https://bugs.webkit.org/show_bug.cgi?id=63558

Attachment 99099: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=99099&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=99099&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:659
> +	   ContentType contentType("");

Might want a why comment for this.

> Source/WebCore/html/HTMLMediaElement.cpp:775
> +    if (!m_player->load(url.string(), contentType))
> +	   mediaLoadingFailed(MediaPlayer::FormatError);

No return here?