[webkit-reviews] review granted: [Bug 63489] [Qt] DRT: Provide LayoutTestController::setDefersLoading and ::goBack support : [Attachment 99091] Patch v2

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Diego Gonzalez
<diegohcg at webkit.org>'s request for review:
Bug 63489: [Qt] DRT: Provide LayoutTestController::setDefersLoading and
::goBack support
https://bugs.webkit.org/show_bug.cgi?id=63489

Attachment 99091: Patch v2
https://bugs.webkit.org/attachment.cgi?id=99091&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99091&action=review

>>> Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:1005
>>> +void DumpRenderTreeSupportQt::goBack(QWebPage* page)
>>> +{
>>> +	 Page* corePage = QWebPagePrivate::core(page);
>>> +	 if (corePage)
>>> +	     corePage->goBack();
>>> +}
>> 
>> How is it different from window.history.back(), diego?
>> 
>> http://www.w3schools.com/jsref/met_his_back.asp
> 
> bool Page::goBack()
> {
>     HistoryItem* item = backForward()->backItem();
> 
>     if (item) {
>	  goToItem(item, FrameLoadTypeBack);
>	  return true;
>     }
>     return false;
> }
> 
> It seems the sameway

How is it different from window.history.back(), diego?

http://www.w3schools.com/jsref/met_his_back.asp