[webkit-reviews] review denied: [Bug 63564] coding-style: Add note about cases where enums are preferred over bools : [Attachment 99083] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Leandro Pereira
<leandro at profusion.mobi>'s request for review:
Bug 63564: coding-style: Add note about cases where enums are preferred over
bools
https://bugs.webkit.org/show_bug.cgi?id=63564

Attachment 99083: Patch
https://bugs.webkit.org/attachment.cgi?id=99083&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=99083&action=review

Thanks. Getting better.

> Websites/webkit.org/coding/coding-style.html:607
> +passing constants, since named constants are easier to read on the call
site. 

Should be "at the call site" rather than "on the call site".

> Websites/webkit.org/coding/coding-style.html:608
> +The only exception would be on setters, where the name of the function

Instead of "The only exception would be on setters," I would say, "An exception
to this rule is a setter function,"

> Websites/webkit.org/coding/coding-style.html:613
> +doSomething(something, AllowFooBar);
> +paintTextWithShadows(context, ..., textStrokeWidth > 0, isHorizontal());

The right example should include a setter that takes a boolean.

> Websites/webkit.org/coding/coding-style.html:618
> +doSomething(something, false);

The wrong example should include a setter that takes an enum.