[webkit-reviews] review denied: [Bug 63376] [DOM] Core part patch for supporting battery status event : [Attachment 98840] Modify description in the ChangeLog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 29 06:38:13 PDT 2011


Leandro Pereira <leandro at profusion.mobi> has denied Kihong Kwon
<kihong.kwon at samsung.com>'s request for review:
Bug 63376: [DOM] Core part patch for supporting battery status event
https://bugs.webkit.org/show_bug.cgi?id=63376

Attachment 98840: Modify description in the ChangeLog
https://bugs.webkit.org/attachment.cgi?id=98840&action=review

------- Additional Comments from Leandro Pereira <leandro at profusion.mobi>
View in context: https://bugs.webkit.org/attachment.cgi?id=98840&action=review

> Source/WebCore/ChangeLog:44
> +	   * bindings/js/JSEventCustom.cpp:
> +	   (WebCore::toJS):
> +	   * bindings/v8/custom/V8EventCustom.cpp:
> +	   (WebCore::toV8):
> +	   * dom/Document.cpp:
> +	   (WebCore::Document::createEvent):
> +	   * dom/Event.cpp:
> +	   (WebCore::Event::isBatteryStatusEvent):
> +	   * dom/Event.h:
> +	   * dom/EventNames.h:
> +	   * page/DOMWindow.cpp:
> +	   (WebCore::DOMWindow::addEventListener):
> +	   (WebCore::DOMWindow::removeEventListener):
> +	   (WebCore::DOMWindow::removeAllEventListeners):
> +	   * page/DOMWindow.h:
> +	   * page/Page.cpp:
> +	   (WebCore::Page::Page):
> +	   (WebCore::Page::PageClients::PageClients):
> +	   * page/Page.h:
> +	   (WebCore::Page::batteryStatusController):

These are added so that you can fill them; no need for a separate section
above, like so:

* page/Page.cpp: Add controller and client for...
...
* page/Page.cpp: Ditto.


More information about the webkit-reviews mailing list