[webkit-reviews] review denied: [Bug 62894] Web Inspector: backend needs to provide system-unique object ids, so these remain unique across navigation : [Attachment 99077] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 62894: Web Inspector: backend needs to provide system-unique object ids, so
these remain unique across navigation
https://bugs.webkit.org/show_bug.cgi?id=62894

Attachment 99077: patch
https://bugs.webkit.org/attachment.cgi?id=99077&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99077&action=review

A couple of nits, otherwise looks ok.

> Source/WebCore/inspector/InspectorController.cpp:352
> +void InspectorController::setAgentProcessIdentifier(unsigned int identifier)


WebCore should not operate 'processes'. Please come up with a neutral name
(AgentUniqueIdentifier?). Also it should probably be a string.