[webkit-reviews] review denied: [Bug 63064] Apply the ParallelJobs support to FEMorphology : [Attachment 99048] Apply the ParallelJobs support to FEMorphology
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 29 04:21:44 PDT 2011
Dirk Schulze <krit at webkit.org> has denied Andras Piroska
<Piroska.Andras at stud.u-szeged.hu>'s request for review:
Bug 63064: Apply the ParallelJobs support to FEMorphology
https://bugs.webkit.org/show_bug.cgi?id=63064
Attachment 99048: Apply the ParallelJobs support to FEMorphology
https://bugs.webkit.org/attachment.cgi?id=99048&action=review
------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99048&action=review
I just have a snippet, a style issue. r- because you don't have commit rights
and can't change it before landing.
> Source/WebCore/platform/graphics/filters/FEMorphology.cpp:183
> + param.endY = (job) ? (currentY) : (paintingData->height);
Can you omit the braces here? They are superfluous and not webkit style.
More information about the webkit-reviews
mailing list