[webkit-reviews] review denied: [Bug 61600] SVGRadialGradientElement::selfHasRelativeLengths() doesn't consider if cx() is relative : [Attachment 99050] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 29 00:43:55 PDT 2011


Dirk Schulze <krit at webkit.org> has denied Ryan Sleevi <rsleevi at chromium.org>'s
request for review:
Bug 61600: SVGRadialGradientElement::selfHasRelativeLengths() doesn't consider
if cx() is relative
https://bugs.webkit.org/show_bug.cgi?id=61600

Attachment 99050: Patch
https://bugs.webkit.org/attachment.cgi?id=99050&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99050&action=review

r- because you're not a commiter yet and can't correct the patch before landing
it.

> Source/WebCore/ChangeLog:9
> +	   No new tests, as there is no way to currently test this. With the
bug present, a side-effect is causing the expected/correct image to be
rendered. This is because the cached SVG resource is getting invalided through
a different path, forcing a repaint. The repaint takes into consideration the
proper dimensions, hiding the bug.

Just a snippet, can you please break the line? This comment is too long to stay
in one line. Lines shouldn't be longer than the line with the sentence "Correct
the logic....".


More information about the webkit-reviews mailing list