[webkit-reviews] review canceled: [Bug 63536] [Chromium] DRT: Add setHixie76WebSocketProtocolEnabled to LayoutTestController : [Attachment 98916] Patch

[bugzilla-daemon at webkit.org]

Yuta Kitamura <yutak at chromium.org> has canceled Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 63536: [Chromium] DRT: Add setHixie76WebSocketProtocolEnabled to
LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=63536

Attachment 98916: Patch
https://bugs.webkit.org/attachment.cgi?id=98916&action=review

------- Additional Comments from Yuta Kitamura <yutak at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98916&action=review

Taking Adam's advice, I would like to use
LayoutTestController::overridePreference(), rather than adding a new method to
LayoutTestController. I'm preparing a new patch.

>> Tools/ChangeLog:8
>> +	    Add a method to LayoutTestController so we can switch WebSocket
protocols in layout tests.
> 
> Why don't you use window.internals?
> See WebCore/testing/Internals.*

I don't think I can use window.internals for this purpose, because we need to
reset preference values for each test run to prevent preference values from
previous runs from leaking to the following tests.