[webkit-reviews] review denied: [Bug 63605] DFG JIT does not perform get_by_id self list caching : [Attachment 99042] the patch (fix style)

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has denied Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 63605: DFG JIT does not perform get_by_id self list caching
https://bugs.webkit.org/show_bug.cgi?id=63605

Attachment 99042: the patch (fix style)
https://bugs.webkit.org/attachment.cgi?id=99042&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=99042&action=review

Looks great! r- to consider the one comment about memory usage.

> Source/JavaScriptCore/bytecode/StructureStubInfo.h:132
> +	   

I think we should probably look at trying to wrap these fields in an #if
ENABLE(DFG_JIT).  These are only used if the DFG_JIT is enabled, and it seems
unfortunate to increase the size of this object on platforms like ARM.	(We may
want to later look at whether we can claw this space back, but if we can make
these fields ENABLE(DFG_JIT) I don't think we need to be worried about this for
now).

Also, along with accessType & seen (above) the size of this set of fields is 9
bytes, which to align the struct below will probably pad out to 16 bytes. 
Probably worth changing accessType & seen to be uint8_t's too, that way all 7
fields should probably pack out to 8 bytes.