[webkit-reviews] review denied: [Bug 56397] Suppress modal JavaScript/HTML dialogs during unload events : [Attachment 99029] Addressed most of abarth's comments; fixed build errors

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Sreeram Ramachandran
<sreeram at chromium.org>'s request for review:
Bug 56397: Suppress modal JavaScript/HTML dialogs during unload events
https://bugs.webkit.org/show_bug.cgi?id=56397

Attachment 99029: Addressed most of abarth's comments; fixed build errors
https://bugs.webkit.org/attachment.cgi?id=99029&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99029&action=review

Looks like we just have some const and Frame/Page nits to clean up.  I'd like
to give the whole patch one more read-through once we've got those sorted out.

> Source/WebKit/chromium/src/ChromeClientImpl.cpp:956
> +    String logMessage = makeString("Blocked ", kDialogs[dialog], "('",
dialogMessage, "') during ", kDismissals[dismissal], ".");
> +   
const_cast<ChromeClientImpl*>(this)->addMessageToConsole(OtherMessageSource,
LogMessageType, ErrorMessageLevel, logMessage, 0, String());

OMG, so much nicer.  Thank you.