[webkit-reviews] review denied: [Bug 63586] Simplify AudioBufferSourceNode rendering : [Attachment 99003] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Chris Rogers <crogers at google.com>'s
request for review:
Bug 63586: Simplify AudioBufferSourceNode rendering
https://bugs.webkit.org/show_bug.cgi?id=63586

Attachment 99003: Patch
https://bugs.webkit.org/attachment.cgi?id=99003&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=99003&action=review

Thanks for walking me through the code offline. Few comments as we discussed.

> Source/WebCore/webaudio/AudioBufferSourceNode.cpp:121
> +	   size_t bufferFramesToProcess = framesToProcess - quantumFrameOffset;


Missing zeroing from the beginning of the quantum to the quantumFrameOffset.

> Source/WebCore/webaudio/AudioBufferSourceNode.cpp:246
> +	   // Final sanity check on buffer access.

Should there be a FIXME to try to get rid of this check, and use assertions and
guards outside the loop instead?

> Source/WebCore/webaudio/AudioBufferSourceNode.h:54
> +    void renderFromBuffer(AudioBus*, unsigned destinationFrameOffset, size_t
numberOfFrames);

This should be private.