[webkit-reviews] review denied: [Bug 63443] [V8] Add missing compile guards for V8Proxy and V8DOMWrapper. : [Attachment 98702] Patch

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has denied Gwang Yoon Hwang
<ryumiel at company100.net>'s request for review:
Bug 63443: [V8] Add missing compile guards for V8Proxy and V8DOMWrapper.
https://bugs.webkit.org/show_bug.cgi?id=63443

Attachment 98702: Patch
https://bugs.webkit.org/attachment.cgi?id=98702&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98702&action=review

> Source/WebCore/bindings/v8/V8DOMWrapper.cpp:53
> +#if ENABLE(FILE_SYSTEM)
>  #include "V8FileWriter.h"
> +#endif // ENABLE(FILE_SYSTEM)

#if ENABLE() shouldn't be necessary around #includes.  CodeGeneratorV8.pm
should correctly putt #if ENABLE() guards around the generated binding headers.


If it isn't properly guarding the headers, we should fix the bug there. :)