[webkit-reviews] review requested: [Bug 63582] [Qt] Regression: Fix for 49650 breaks custom QNAM implementations... : [Attachment 98998] proposed patchgit diff

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 28 16:37:48 PDT 2011


Dawit A. <adawit at kde.org> has asked  for review:
Bug 63582: [Qt] Regression: Fix for 49650 breaks custom QNAM implementations...
https://bugs.webkit.org/show_bug.cgi?id=63582

Attachment 98998: proposed patchgit diff
https://bugs.webkit.org/attachment.cgi?id=98998&action=review

------- Additional Comments from Dawit A. <adawit at kde.org>
The proposed patch uses Qt's Meta Object system, namely a dynamic property, to
address this issue. If the dynamic property "SKIP_QTBUG_18718_WORKAROUND" is
set, the unsupportedContent signal will be invoked directly. Otherwise, the
signal connection will be queued until control returns to the event loop.


More information about the webkit-reviews mailing list