[webkit-reviews] review granted: [Bug 32006] webkit-patch post, post-commits, upload should warn when posting to a closed bug, and offer to reopen it : [Attachment 98964] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 32006: webkit-patch post, post-commits, upload should warn when posting to
a closed bug, and offer to reopen it
https://bugs.webkit.org/show_bug.cgi?id=32006

Attachment 98964: Patch
https://bugs.webkit.org/attachment.cgi?id=98964&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98964&action=review

I'd add the user confirmation step, but that's a judgement call.

> Tools/Scripts/webkitpy/tool/steps/ensurebugisopenandassigned.py:41
> +	   if bug.is_closed():
> +	       # FIXME: We should probably pass this message in somehow?
> +	       # Right now this step is only used before PostDiff steps, so
this is OK.
> +	       self._tool.bugs.reopen_bug(bug.id(), "Reopening to attach new
patch.")

It sucks that bugzilla needs you to spam a bug in order to re-open it.	Why not
ask the user to confirm before doing this?