[webkit-reviews] review denied: [Bug 63555] [Qt] GraphicsContext::clipToImageBuffer does not support scale transformation : [Attachment 98963] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Igor Trindade Oliveira
<itrindade.oliveira at gmail.com>'s request for review:
Bug 63555: [Qt] GraphicsContext::clipToImageBuffer does not support scale
transformation
https://bugs.webkit.org/show_bug.cgi?id=63555

Attachment 98963: Patch
https://bugs.webkit.org/attachment.cgi?id=98963&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98963&action=review

> Source/WebCore/ChangeLog:10
> +	   No new tests. (OOPS!)

Oops indeed! The commit-queue will choke on this line, replace it with one of
these three:
1) Tests: list of tests that exercise this change...
2) No new tests because...
3) Awkward silence.

> Source/WebCore/platform/graphics/qt/ImageBufferQt.cpp:167
> +    QRectF deviceClip =
context->platformContext()->transform().mapRect(floatRect);
> +    if (alphaMask.width() != deviceClip.width() || alphaMask.height() !=
deviceClip.height())
> +	   alphaMask = alphaMask.scaled(deviceClip.width(),
deviceClip.height());

We should do this in GraphicsContext::pushTransparencyLayerInternal() instead,
then we avoid doing mapRect() twice, and ImageBuffer doesn't need to know about
any painter transforms.