[webkit-reviews] review granted: [Bug 63390] SVG1.1SE test text-tref-03-b.svg fails : [Attachment 98922] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Rob Buis
<rwlbuis at gmail.com>'s request for review:
Bug 63390: SVG1.1SE test text-tref-03-b.svg fails
https://bugs.webkit.org/show_bug.cgi?id=63390

Attachment 98922: Patch
https://bugs.webkit.org/attachment.cgi?id=98922&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98922&action=review

Looks great, r=me with some comments:

> Source/WebCore/svg/SVGTRefElement.cpp:160
> +	   if (renderer())
> +	      
RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer());

You could use: if (RenderObject* renderer = this->renderer()) to save calling
it twice.

> Source/WebCore/svg/SVGTRefElement.cpp:234
> +    if (Element* target = treeScope()->getElementById(id)) {

I'd rather use a early return here.

> Source/WebCore/svg/SVGTRefElement.cpp:249
> +    if (m_eventListener) {

This condition is superfluous.