[webkit-reviews] review denied: [Bug 62837] [chromium]Optimize GraphicsLayerChromium::setChildren : [Attachment 98867] newPatch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 28 10:58:51 PDT 2011
Kenneth Russell <kbr at google.com> has denied zeng huiqing
<huiqing.zeng at intel.com>'s request for review:
Bug 62837: [chromium]Optimize GraphicsLayerChromium::setChildren
https://bugs.webkit.org/show_bug.cgi?id=62837
Attachment 98867: newPatch
https://bugs.webkit.org/attachment.cgi?id=98867&action=review
------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=98867&action=review
> Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp:136
> // FIXME: GraphicsLayer::setChildren calls addChild() for each child,
which
> // will end up calling updateChildList() N times.
You forgot to remove this FIXME.
More information about the webkit-reviews
mailing list