[webkit-reviews] review granted: [Bug 63445] [GTK] Add back/forward menu to MiniBrowser toolbar : [Attachment 98739] Updated patch according to review

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 63445: [GTK] Add back/forward menu to MiniBrowser toolbar
https://bugs.webkit.org/show_bug.cgi?id=63445

Attachment 98739: Updated patch according to review
https://bugs.webkit.org/attachment.cgi?id=98739&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98739&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:298
> +    gchar *name = WKURLGetCString(url);
> +    WKRelease(url);
> +
> +    WKStringRef title = WKBackForwardListItemCopyTitle(item);
> +    gchar *label = WKStringGetCString(title);
> +    WKRelease(title);
> +
> +    GtkAction *action = gtk_action_new(name, label, 0, 0);
> +    g_free(name);
> +    g_free(label);
> +
> +    return action;

I think it's more appropriate to use char and bare free here since these types
aren't allocated by GLib.

> Tools/MiniBrowser/gtk/BrowserWindow.c:330
> +    guint i;
> +
> +    if (!list)
> +	   return 0;
> +
> +    guint listCount = WKArrayGetSize(list);
> +    if (!listCount)
> +	   return 0;
> +
> +    GtkWidget *menu = gtk_menu_new();
> +    gboolean hasItems = FALSE;
> +    for (i = 0; i < listCount; i++) {

Please declare i just above the for for loop instead of at the top.