[webkit-reviews] review granted: [Bug 63532] [Mac, Win] DRT: Add setHixie76WebSocketProtocolEnabled to LayoutTestController : [Attachment 98915] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 63532: [Mac, Win] DRT: Add setHixie76WebSocketProtocolEnabled to
LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=63532

Attachment 98915: Patch
https://bugs.webkit.org/attachment.cgi?id=98915&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98915&action=review

Going forward, this really needs a WebKit2 implementation, too.

> Tools/DumpRenderTree/LayoutTestController.cpp:2139
> +    if (argumentCount == 1)
> +	  
controller->setHixie76WebSocketProtocolEnabled(JSValueToBoolean(context,
arguments[0]));

A function with this name could enable it when called with no arguments, too.
That could save someone a few minutes of confusion some day.