[webkit-reviews] review denied: [Bug 63191] accessibility/aria-labelledby-overrides-aria-label.html failing on Windows since it was added : [Attachment 98839] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 28 08:23:50 PDT 2011


Adam Roben (:aroben) <aroben at apple.com> has denied Alice Boxhall
<aboxhall at chromium.org>'s request for review:
Bug 63191: accessibility/aria-labelledby-overrides-aria-label.html failing on
Windows since it was added
https://bugs.webkit.org/show_bug.cgi?id=63191

Attachment 98839: Patch
https://bugs.webkit.org/attachment.cgi?id=98839&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
Seems like the Windows results need to be updated, not just deleted. Maybe
that's what you meant by "interim"? If so, you probably shouldn't have marked
the patch r?.

It's really unfortunate that we have to duplicate the test for the two
platforms. Maybe we should just dump the attributes instead of using shouldBe?
Then each platform could have its own expected results using the same test and
you wouldn't have any FAIL text.


More information about the webkit-reviews mailing list