[webkit-reviews] review granted: [Bug 63529] SVGAnimatedType should support SVGBoolean animation : [Attachment 98908] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 63529: SVGAnimatedType should support SVGBoolean animation
https://bugs.webkit.org/show_bug.cgi?id=63529

Attachment 98908: Patch
https://bugs.webkit.org/attachment.cgi?id=98908&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98908&action=review

r=me. Don't forget the mac-wk2/qt-wk2/etc. Skipped list update! Otherwhise ossy
will complain :-)

> Source/WebCore/svg/SVGAnimatedBoolean.cpp:36
> +    DEFINE_STATIC_LOCAL(const AtomicString, trueString, ("true"));

Why AtomicString here?? Use String.