[webkit-reviews] review denied: [Bug 61025] Speed up SVGSMILElement::findInstanceTime : [Attachment 98900] Speed up SVGSMILElement::findInstanceTime

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Oliver Varga
<Varga.Oliver at stud.u-szeged.hu>'s request for review:
Bug 61025: Speed up SVGSMILElement::findInstanceTime
https://bugs.webkit.org/show_bug.cgi?id=61025

Attachment 98900: Speed up SVGSMILElement::findInstanceTime
https://bugs.webkit.org/attachment.cgi?id=98900&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98900&action=review

> Source/JavaScriptCore/ChangeLog:8
> +	   Add a new parameter to StdlibExtras.h::binarySerarch function
> +	   to also handle cases when the array does not contain the key value.
> +	   This is needed for an svg function.
> +	   https://bugs.webkit.org/show_bug.cgi?id=61025

This is the part which is wrong. The WebKit ChangeLog style is:

Reviewed by NOBODY (OOPS!).

Speed up SVGSMILElement::findInstanceTime
https://bugs.webkit.org/show_bug.cgi?id=61025

Your text goes here.

> Source/WebCore/ChangeLog:11
> +
> +	   Replace the linear search to binary search on ordered list.
> +	   https://bugs.webkit.org/show_bug.cgi?id=61025
> +
> +	   Speed up SVGSMILElement::findInstanceTime because
> +	   the previous searches from the beginning was not efficient.
> +
> +	   No new tests this is only a performance tweak.

This has the correct ChangeLog style bug the wrong bug title
the title is "Speed up SVGSMILElement::findInstanceTime" not "Replace the
linear search to binary search.." -- that should go into the description text.