[webkit-reviews] review denied: [Bug 61025] Speed up SVGSMILElement::findInstanceTime : [Attachment 98887] Speed up SVGSMILElement::findInstanceTime
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 28 04:24:41 PDT 2011
Nikolas Zimmermann <zimmermann at kde.org> has denied Oliver Varga
<Varga.Oliver at stud.u-szeged.hu>'s request for review:
Bug 61025: Speed up SVGSMILElement::findInstanceTime
https://bugs.webkit.org/show_bug.cgi?id=61025
Attachment 98887: Speed up SVGSMILElement::findInstanceTime
https://bugs.webkit.org/attachment.cgi?id=98887&action=review
------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98887&action=review
Almost r+, but the ChangeLog is wrong :(
> Source/JavaScriptCore/ChangeLog:8
> + Added a new parameter to StdlibExtras.h::binarySerarch function,
> + for the case when not sure that the array contains the key value.
> + It is needed for an svg function.
> + https://bugs.webkit.org/show_bug.cgi?id=61025
ChangeLog still is wrong, please fix it first.
More information about the webkit-reviews
mailing list