[webkit-reviews] review denied: [Bug 63377] [EFL] Remove unused code related with priv->render.process_entire_queue in ewk_tiled_backing_store : [Attachment 98829] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 28 01:29:40 PDT 2011


Kenneth Rohde Christiansen <kenneth at webkit.org> has denied KwangHyuk
<hyuki.kim at samsung.com>'s request for review:
Bug 63377: [EFL] Remove unused code related with
priv->render.process_entire_queue in ewk_tiled_backing_store
https://bugs.webkit.org/show_bug.cgi?id=63377

Attachment 98829: Patch
https://bugs.webkit.org/attachment.cgi?id=98829&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98829&action=review

Why is the cq set to cq+? That is wrong - the patch is not even reviewed yet.

> Source/WebKit/efl/ChangeLog:8
> +	   As priv->render.process_entire_queue affects no logical flow of
ewk_tiled_backing_store but setter api,

I don't understand what you are saying here, please rephrase. And please tell
why it is fine to remove that setter API?


More information about the webkit-reviews mailing list