[webkit-reviews] review granted: [Bug 61600] SVGRadialGradientElement::selfHasRelativeLengths() doesn't consider if cx() is relative : [Attachment 95106] Attempt to fix style errors

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Ryan Sleevi <rsleevi at chromium.org>'s
request for review:
Bug 61600: SVGRadialGradientElement::selfHasRelativeLengths() doesn't consider
if cx() is relative
https://bugs.webkit.org/show_bug.cgi?id=61600

Attachment 95106: Attempt to fix style errors
https://bugs.webkit.org/attachment.cgi?id=95106&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95106&action=review

r=m, but please fix the changelog. Not sure if you have commit rights. If not,
please upload a new patch and set 'r' and 'cq' to '?'. I'll review it again.

> ChangeLog:8
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Correct the logic for checking for relative lengths in an
SVGRadialGradientElement to consider cx() in addition to cy()
> +	   https://bugs.webkit.org/show_bug.cgi?id=61600.
> +
> +	   * Source/WebCore/svg/SVGRadialGradientElement.cpp:

This should be:

Reviewed by NOBODY (OOPS!).

SVGRadialGradientElement::selfHasRelativeLengths() doesn't consider if cx() is
relative
https://bugs.webkit.org/show_bug.cgi?id=61600.

Correct the logic for checking for relative lengths in an
SVGRadialGradientElement to consider cx() in addition to cy()

...

(With correct indention of course)
Please add a comment that there is no way to test it and why it can't be tested
as well.