[webkit-reviews] review denied: [Bug 63362] convert editing/deleting/paragraph-in-preserveNewline.html to dumpAsText : [Attachment 98862] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Wyatt Carss <wcarss at chromium.org>'s
request for review:
Bug 63362: convert editing/deleting/paragraph-in-preserveNewline.html to
dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=63362

Attachment 98862: Patch
https://bugs.webkit.org/attachment.cgi?id=98862&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98862&action=review

> LayoutTests/editing/deleting/paragraph-in-preserveNewline-expected.txt:6
> +| <pre>
> +|   "<#selection-caret>
> +bar"

Huh, bar is outside of pre?  Please file a bug for this.

> LayoutTests/editing/deleting/paragraph-in-preserveNewline.html:20
> +if (window.layoutTestController)
> +	layoutTestController.dumpEditingCallbacks();

You need to do this before modifying selection & calling execCommand("Delete").
 r- because of this.