[webkit-reviews] review granted: [Bug 55987] input type=email and multiple is not compliant : [Attachment 98855] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Kentaro Hara
<haraken at google.com>'s request for review:
Bug 55987: input type=email and multiple is not compliant
https://bugs.webkit.org/show_bug.cgi?id=55987

Attachment 98855: Patch
https://bugs.webkit.org/attachment.cgi?id=98855&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98855&action=review

> Source/WebCore/html/EmailInputType.h:49
> +    virtual String sanitizeValue(const String& proposedValue);

No need to write the argument name.

> Source/WebCore/html/parser/HTMLParserIdioms.cpp:72
> +    StringBuilder builder;
> +    for (unsigned i = 0; i < length; i++) {
> +	   if (!isHTMLLineBreak(string[i]))
> +	       builder.append(string[i]);
> +    }
> +    return builder.toString();

- You can avoid to build StringBuilder if the input string has no line breaks.
- You had better call builder.reserveCapacity(length).