[webkit-reviews] review granted: [Bug 63469] Clean up integer clamping functions in MathExtras.h and support arbitrary numeric types and limits. : [Attachment 98841] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 63469: Clean up integer clamping functions in MathExtras.h and support
arbitrary numeric types and limits.
https://bugs.webkit.org/show_bug.cgi?id=63469

Attachment 98841: Patch
https://bugs.webkit.org/attachment.cgi?id=98841&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I still don’t understand why we have to convert the float to a double to
convert it to an int. I understand that int has more precision than a float
does in the range of int, but I don’t understand why we can’t do a correct
conversion without first converting to double. At some point I would love to
have an answer to that.