[webkit-reviews] review requested: [Bug 63315] [EFL] Add notifier API of network state to ewk : [Attachment 98837] Modified Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has asked  for review:
Bug 63315: [EFL] Add notifier API of network state to ewk
https://bugs.webkit.org/show_bug.cgi?id=63315

Attachment 98837: Modified Patch
https://bugs.webkit.org/attachment.cgi?id=98837&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
>> IMO, this could be done in ewk_settings. 

Yes, I also thought this API can be done in ewk_settings. But, I think we need
to add more APIs related to network states in future. For example, we need to
notify some events to application when network is disconnected. So, I think it
is better to make new files for this. 


>> The `online' is not necessary here (I thought the style bot would complain
about this).
If type of parameter represents parameter's name well, AFAIK, we don't need to
add name of parameter. However, Eina_Bool doesn't express *online* meaning
clearly.