[webkit-reviews] review granted: [Bug 57640] [GTK] overlapping drag&drop tests fail on NRWT : [Attachment 96588] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 57640: [GTK] overlapping drag&drop tests fail on NRWT
https://bugs.webkit.org/show_bug.cgi?id=57640

Attachment 96588: Patch
https://bugs.webkit.org/attachment.cgi?id=96588&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96588&action=review

> Tools/Scripts/webkitpy/layout_tests/port/gtk.py:51
> +	       "DumpRenderTree", self.cmd_line(), environment)

"DumpRenderTree" should probably self._port.driver_name() since you'll want to
support WebKit2.

> Tools/Scripts/webkitpy/layout_tests/port/gtk.py:67
> +	   """Starts a new Driver and returns a handle to it."""

I'd get rid of this docstring.