[webkit-reviews] review granted: [Bug 63482] Allow non-main thread text drawing in ICU ports : [Attachment 98789] [PATCH] Put a Pool in ThreadGlobalData for ICU

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 63482: Allow non-main thread text drawing in ICU ports
https://bugs.webkit.org/show_bug.cgi?id=63482

Attachment 98789: [PATCH] Put a Pool in ThreadGlobalData for ICU
https://bugs.webkit.org/attachment.cgi?id=98789&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=98789&action=review

>> Source/WebCore/platform/ThreadGlobalData.cpp:89
>> +	    m_lineBreakIteratorPool = new LineBreakIteratorPool();
> 
> Normal style is probably to drop the parens. I'll drop them.

I like it better without the parens, yes.

> Source/WebCore/platform/ThreadGlobalData.cpp:107
> +    if (m_lineBreakIteratorPool) {
> +	   delete m_lineBreakIteratorPool;
> +	   m_lineBreakIteratorPool = 0;
> +    }

No need for the if statement. The delete operator already checks for 0.

>> Source/WebCore/platform/ThreadGlobalData.h:79
>> +	    LineBreakIteratorPool* m_lineBreakIteratorPool;
> 
> Can this be an OwnPtr?

I think using an OwnPtr for this would be good.