[webkit-reviews] review denied: [Bug 62916] WebCore fails to compile in thumb mode when neon instructions are enabled. : [Attachment 98444] Force -marm to be passed when building these files.

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Raymes Khoury <raymes at google.com>'s
request for review:
Bug 62916: WebCore fails to compile in thumb mode when neon instructions are
enabled.
https://bugs.webkit.org/show_bug.cgi?id=62916

Attachment 98444: Force -marm to be passed when building these files. 
https://bugs.webkit.org/attachment.cgi?id=98444&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98444&action=review

Just some minor style nits.

> WebCore/ChangeLog:7
> +	   enabled. There are two files (FELightingNEON.cpp and
> +	   FELightingNEON.cpp) which fail to build when -mthumb is

I think you mean to mention FEGaussianBlur.cpp here.

> WebCore/WebCore.gyp/WebCore.gyp:1313
> +	   ['exclude', 'platform/graphics/filters/arm/.*NEON\\.(cpp|h)'],

Nit: Sort the excludes alphabetically.	You might want to add a comment above
this saying that these files are compiled into webcore_arm_neon.

> WebCore/WebCore.gyp/WebCore.gyp:1693
> +	   'webcore_arm_neon',

Nit: Sort these alphabetically too.