[webkit-reviews] review granted: [Bug 63479] webkitpy unit tests should have more descriptive names than just "Test" : [Attachment 98780] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 27 14:09:40 PDT 2011


Dirk Pranke <dpranke at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 63479: webkitpy unit tests should have more descriptive names than just
"Test"
https://bugs.webkit.org/show_bug.cgi?id=63479

Attachment 98780: Patch
https://bugs.webkit.org/attachment.cgi?id=98780&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
The changes look fine, but aren't the names scoped to the module? I would think
it would only be a problem if someone was importing "*" from multiple modules,
which is not AFAIK normally done.

Also, I notice that you are deleting the "if __name__ == '__main__' clauses ...
as I've mentioned before, I use that functionality all the time and would
prefer you not delete them unless you had a strong reason to do so.


More information about the webkit-reviews mailing list