[webkit-reviews] review granted: [Bug 56393] Crash on www.crave.cnet.com in FrameView::windowClipRect() : [Attachment 97845] Check for a null renderer to avoid a crash.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Joe Wild
<joseph.wild at nokia.com>'s request for review:
Bug 56393: Crash on www.crave.cnet.com in FrameView::windowClipRect()
https://bugs.webkit.org/show_bug.cgi?id=56393

Attachment 97845: Check for a null renderer to avoid a crash.
https://bugs.webkit.org/attachment.cgi?id=97845&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=97845&action=review

> Source/WebCore/ChangeLog:8
> +	   Check for a null renderer to fix a reset. This situation can

s/reset/crash

> Source/WebCore/page/FrameView.cpp:2130
> +    RenderLayer* layer = 0;
> +    // The renderer can sometimes be null when style="display:none"
interacts
> +    // with external content and plugins.
> +    if (elt->renderer())
> +	   layer = elt->renderer()->enclosingLayer();

You could write this as layer = elt->renderer() ?
elt->renderer()->enclosingLayer().