[webkit-reviews] review denied: [Bug 63419] Add encoding parameter to filesystem.py functions : [Attachment 98668] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has denied Roland Steiner
<rolandsteiner at chromium.org>'s request for review:
Bug 63419: Add encoding parameter to filesystem.py functions
https://bugs.webkit.org/show_bug.cgi?id=63419

Attachment 98668: Patch
https://bugs.webkit.org/attachment.cgi?id=98668&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98668&action=review

These interfaces were intentionally designed so that the caller did not have to
worry about the encoding, and that if if a file was being passed to the text
versions of these routines, we could be fairly certain it was stored on disk as
utf-8. I do not want to lose those principles lightly.

Until there's multiple callers that need this functionality, I would prefer it
if you just used the read/write_binary_file routines and did the
encoding/decoding in the calling routine instead (like Tony suggests). Is that
okay?

>> Tools/Scripts/webkitpy/common/system/filesystem.py:-199
>> -	def open_text_file_for_writing(self, path, append=False):
> 
> There were no callsites hitherto using append?

I think that that is correct. I think I added it at one point and ended up not
needing it.