[webkit-reviews] review granted: [Bug 63471] Extract LineBreakIteratorPool class into its own file : [Attachment 98763] [PATCH] Add LineBreakIteratorPoolICU.h

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 63471: Extract LineBreakIteratorPool class into its own file
https://bugs.webkit.org/show_bug.cgi?id=63471

Attachment 98763: [PATCH] Add LineBreakIteratorPoolICU.h
https://bugs.webkit.org/attachment.cgi?id=98763&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=98763&action=review

> Source/WebCore/platform/text/LineBreakIteratorPoolICU.h:2
> + * Copyright (C) 2006 Lars Knoll <lars at trolltech.com>

Lars shouldn’t get copyright for this new code.

> Source/WebCore/platform/text/LineBreakIteratorPoolICU.h:3
> + * Copyright (C) 2007 Apple Inc. All rights reserved.

The code you put into this file is all new. The copyright should be 2011, not
2007.

> Source/WebCore/platform/text/LineBreakIteratorPoolICU.h:34
> +WTF_MAKE_NONCOPYABLE(LineBreakIteratorPool);

I think this should be indented.