[webkit-reviews] review denied: [Bug 62698] [DOM] Support for battery status event : [Attachment 97938] Add mock class for client and change event name to 'webkit' prefix adding.

[bugzilla-daemon at webkit.org]

Leandro Pereira <leandro at profusion.mobi> has denied Kihong Kwon
<kihong.kwon at samsung.com>'s request for review:
Bug 62698: [DOM] Support for battery status event
https://bugs.webkit.org/show_bug.cgi?id=62698

Attachment 97938: Add mock class for client and change event name to 'webkit'
prefix adding.
https://bugs.webkit.org/attachment.cgi?id=97938&action=review

------- Additional Comments from Leandro Pereira <leandro at profusion.mobi>
View in context: https://bugs.webkit.org/attachment.cgi?id=97938&action=review

> Source/WebCore/dom/BatteryStatusClient.h:34
> +    virtual void setBatteryStatus(bool isPlugged, float level) = 0;

Prefer enums to booleans.

> Source/WebCore/dom/BatteryStatusController.cpp:74
> +    Vector<RefPtr<DOMWindow> > listenersVector;

Stray space after <DOMWindow>.

> Source/WebCore/dom/BatteryStatusController.cpp:78
> +    for (size_t i = 0; i < listenersVector.size(); ++i)
> +	   listenersVector[i]->dispatchEvent(event);

You should use a better name than 'i'.

> Source/WebCore/dom/BatteryStatusController.h:43
> +    void didChangeBatteryStatus(bool isPlugged, float level);

Prefer enums to booleans. Also, no parameter names on header files.

> Source/WebCore/dom/BatteryStatusController.h:50
> +    typedef HashCountedSet<RefPtr<DOMWindow> > ListenersCountedSet;

Stray space after <DOMWindow>.