[webkit-reviews] review denied: [Bug 63404] [GTK] Allow to build WebKitGtk+ with accelerated compositing : [Attachment 98652] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 27 09:17:50 PDT 2011


Martin Robinson <mrobinson at webkit.org> has denied Joone Hur
<joone.hur at collabora.co.uk>'s request for review:
Bug 63404: [GTK] Allow to build WebKitGtk+ with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=63404

Attachment 98652: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=98652&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98652&action=review

> Source/JavaScriptCore/wtf/Platform.h:1138
> +#if PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(QT) || (PLATFORM(WIN) &&
!OS(WINCE) &&!defined(WIN_CAIRO)) || PLATFORM(EFL) || PLATFORM(GTK)

I don't think we should turn it on by default until it's implemented. The other
parts of this change look good.


More information about the webkit-reviews mailing list