[webkit-reviews] review denied: [Bug 62997] [Qt] Add shadowblur support : [Attachment 98709] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Igor Trindade Oliveira
<itrindade.oliveira at gmail.com>'s request for review:
Bug 62997: [Qt] Add shadowblur support
https://bugs.webkit.org/show_bug.cgi?id=62997

Attachment 98709: Patch
https://bugs.webkit.org/attachment.cgi?id=98709&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=98709&action=review

> Source/WebCore/platform/graphics/ShadowBlur.cpp:262
> +bool ShadowBlur::mustUseShadowBlur(GraphicsContext* context) const
> +{
> +    // We can't avoid ShadowBlur, since the shadow has blur.
> +    if (m_type == ShadowBlur::BlurShadow)
> +	   return true;
> +    // We can avoid ShadowBlur and optimize, since we're not drawing on a
> +    // canvas and box shadows are affected by the transformation matrix.
> +    if (!shadowsIgnoreTransforms())
> +	   return false;
> +    // We can avoid ShadowBlur, since there are no transformations to apply
to the canvas.
> +    if (context->getCTM().isIdentity())
> +	   return false;
> +    // Otherwise, no chance avoiding ShadowBlur.
> +    return true;
> +}

This code doesn't belong here. It's asking Qt-specific questions. I see no
reason why some other class can't ask the same questions.