[webkit-reviews] review granted: [Bug 63456] SVGAnimatedType should support SVGPreserveAspectRatio animation : [Attachment 98730] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 63456: SVGAnimatedType should support SVGPreserveAspectRatio animation
https://bugs.webkit.org/show_bug.cgi?id=63456

Attachment 98730: Patch
https://bugs.webkit.org/attachment.cgi?id=98730&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98730&action=review

Looks great, please fix up some thing and make sure it actually builds. If you
prefer, you can also upload a new one.

> Source/WebCore/svg/SVGAnimatedPreserveAspectRatio.cpp:57
> +    // Not specified what to do on 'by'-animations with
SVGPreserveAspectRatio. Fallback to 'to'-animation right now. 
> +    from = constructFromString(fromString);
> +    to = constructFromString(byString);

I used ASSERT_NOT_REACHED here for in SVGAnimatedPathAnimator, and made sure
AnimatedPath is not added to the switch() which calls calcFromAndByValues.
Isn't that better than to fail silently?

> Source/WebCore/svg/SVGAnimatedPreserveAspectRatio.cpp:77
> +    // No paced animations for SVGPreserveAspectRatio.

Add the other FIXME?

> Source/WebCore/svg/SVGAnimatedType.h:77
> +    // Used for parsing a String to a SVGPreserveAspectRatio object.
> +    void setPreserveAspectRatioBaseValue(const SVGPreserveAspectRatio&);

Hm, you are not using this method anywhere?

> Source/WebCore/svg/SVGAnimatedType.h:-84
> -	   // FIXME: More SVG primitive types need to be added step by step.

Are we done? bool* and ushort* is still missing, no?