[webkit-reviews] review denied: [Bug 30080] Web Inspector: Show content for plugin requests in network panel. : [Attachment 98342] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 27 02:29:13 PDT 2011
Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 30080: Web Inspector: Show content for plugin requests in network panel.
https://bugs.webkit.org/show_bug.cgi?id=30080
Attachment 98342: Patch
https://bugs.webkit.org/attachment.cgi?id=98342&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98342&action=review
> Source/WebCore/inspector/NetworkResourcesData.cpp:182
> + m_contentSize -= resourceData->purgeContent();
This is clearly worth a test.
> Source/WebCore/inspector/NetworkResourcesData.h:68
> + bool hasData() const { return m_dataBuffer; }
Make these private + a friend of the NetworkResourceData.
More information about the webkit-reviews
mailing list